Ryujinx icon indicating copy to clipboard operation
Ryujinx copied to clipboard

[Feature Request] UPNP port forwarding settings

Open wandbrandon opened this issue 3 years ago • 7 comments

Feature Request

What feature are you suggesting?

Overview:

port forwarding or server creation setting so i don’t need to enable UPNP on my router. Which is insecure anyway.

Smaller Details:

N/A

Nature of Request:

  • Addition
    • server in the US or p2p with selected ports to port forward.
  • Change
  • Removal

Why would this feature be useful?

This will allow people without upnp enabled to still enjoy p2p speeds.

wandbrandon avatar Sep 01 '22 12:09 wandbrandon

Which is insecure anyway.

There are reasons to use port forwarding over UPnP. This is not one of them.

The whole path for communicating over TCP is likely to go away soon, so I'm hesitant to do any more work on it.

riperiperi avatar Sep 01 '22 13:09 riperiperi

Regardless of security, some routers come with it disabled as default. My AT&T router won't even provide it as an option, requiring me to use passthrough with another 3rd party router.

I guess it's irrelevant because in the future you will scrub TCP. What will take it's place? Is there a workaround for now?

wandbrandon avatar Sep 01 '22 13:09 wandbrandon

The workaround is to find a host with UPnP enabled. The replacement will be UDP (with an optional reliability layer) and the usual set of STUN/TURN features for NAT traversal. Consumer networking hardware and ISPs are much more accepting of this approach and it should be more compatible.

riperiperi avatar Sep 01 '22 13:09 riperiperi

Thanks for the quick response. So no capability to manually port forward for UPNP?

Also, as long as the host has UPNP enabled, then all users who join will connect through p2p?

wandbrandon avatar Sep 01 '22 13:09 wandbrandon

The version of LDN released right now tries UPnP, then forcibly falls back if it fails. That includes detecting if UPnP is unavailable, or if it returned an error when attempting to open the port. There's not really any way to get it to forcibly host.

All clients connect to the room host right now, so only the host needs UPnP to open the port.

riperiperi avatar Sep 01 '22 13:09 riperiperi

Hello, wondering if the newest version of LDN still uses UPNP or is a UDP and the usual set of STUN/TURN features for NAT traversal implementation available.

wandbrandon avatar Nov 23 '22 01:11 wandbrandon

It still uses UPnP

jduncanator avatar Nov 23 '22 01:11 jduncanator