Ryujinx icon indicating copy to clipboard operation
Ryujinx copied to clipboard

fatal: Implement Service

Open AcK77 opened this issue 3 years ago • 3 comments

This PR adds a basic implementation of fatal service, guest processes call it when there is something wrong. But since we can already have all informations by debugging it's not really useful. In any case, that's avoid an unimplemented service exception. Structs/Enum are based on Atmosphère source code.

After logs the error report, I call SvcBreak. Feedbacks are welcome on this, since some guests calls it right after fatal service so I can remove it if needed.

(Closes #83 ~finally~)

image

AcK77 avatar Aug 11 '22 14:08 AcK77

Where are the CPU context values supposed to come from? Seems odd that they are all 0s, and some of those CPU registers can only be read by kernel.

gdkchan avatar Aug 26 '22 15:08 gdkchan

Code looks OK, but it is weird that the example is passing a cpu context that is all 0s.

riperiperi avatar Sep 19 '22 12:09 riperiperi