DS4Windows icon indicating copy to clipboard operation
DS4Windows copied to clipboard

DS4Windows crashes when profiles with certain macros are loaded.

Open rarikuma opened this issue 1 year ago • 1 comments

Describe the bug DS4Windows crashes when profiles with certain macros are loaded.

To Reproduce Steps to reproduce the behavior:

  1. Prepare a profile with a specific macro that triggers a DS4Windows crash.
  2. Connect the controller and load the problem profile.
  3. DS4Windows crashes.

Logs and Controller Profile ds4windows_log.txt Controller Profile.xml.txt

Desktop (please complete the following information):

  • Controller Make and Model: Nintendo Switch Pro Controller
  • OS: Windows 11 Enterprise 23H2 Build 22631.2861
  • DS4Windows Version 3.3.0 x64

Additional context The macro used is as follows

<Capture>91/164/44/400/91/164/44</Capture>

Screenshot Game Bar Captures 2023_12_20 23_00_24

rarikuma avatar Dec 20 '23 12:12 rarikuma

There was an array length issue with macroDone. Made some small changes to get the relevant arrays more in sync. Tested and binding a macro to Capture works.

https://github.com/Ryochan7/DS4Windows/commit/af17a6c6e20309c31b30c4d012fcb0c49f6d7901

Ryochan7 avatar Dec 20 '23 21:12 Ryochan7