angular-hammer icon indicating copy to clipboard operation
angular-hammer copied to clipboard

preventGhosts not needed?

Open johnpapa opened this issue 9 years ago • 2 comments

I'm trying to verify that ng-click is indeed firing if I do not set prevetnGhosts. however my sample is not showing any ng-clicks being evented , so I checked out your demo (see link below) and it is also not showing anything for any ng-clicks. Does this mean preventGhosts is no longer needed? Or do I misunderstand the purpose?

http://ryanmullins.github.io/angular-hammer/examples/raw/tap

Also, the demo does not record anything at all when tapping or clicking on the 2nd and 4th options (recognizer with prevent ghosts and stop propogation)

johnpapa avatar Mar 23 '15 00:03 johnpapa

I got "ghost clicks" on hm-tap directive handlers with chrome's device emulation of "Notebook with touch". So first touchstart and touchend fire (triggering hammer's tap event) and then mousedown->mouseup->click guys come up, also triggering hammer's tap.

Though currently I can only test it in chrome's emulation (got no real device available).

kosich avatar Mar 31 '15 16:03 kosich

Can you please verify this issue persists with the changes from #55 and update this issue.

RyanMullins avatar Jun 19 '15 12:06 RyanMullins