devportfolio icon indicating copy to clipboard operation
devportfolio copied to clipboard

Un-hardcode all colors to allow for dark themes

Open yousefamar opened this issue 7 years ago • 2 comments

First of all, love this template. I use a pug port at http://yousefamar.com (GitHub). You'll notice I like things dark. I remember there was some talk of themes. Short of that, I think it might be useful to have all the remaining colors that are hardcoded in become variables up top too, to at least be able to tweak for colors for dark themes. I've already done this for my version though I ended up doing my own hardcoding and we've diverged quite a bit. That way, having a dark theme could just be a matter of uncommenting a block of variables on the top (and lightens becoming darkens automatically).

yousefamar avatar May 27 '17 13:05 yousefamar

Great idea and I like your colour scheme! I'll definitely get this into the next release so there is more flexibility when it comes to actual colour customization, I especially like the idea of being able to easily transition between lighten and darken based on the type of colours you decide to go for.

RyanFitzgerald avatar May 31 '17 12:05 RyanFitzgerald

Funnily enough, I too am using pug for my version!

jessb321 avatar Jun 20 '17 05:06 jessb321