HackerRank icon indicating copy to clipboard operation
HackerRank copied to clipboard

Created JS solution

Open kevindelsh opened this issue 6 years ago • 3 comments

kevindelsh avatar Jan 13 '19 15:01 kevindelsh

You need to add two things in every pull request to get your pull request accepted apart from the program:

  1. Please add a thoughts section in your solution file where you outline the key steps followed in solving the problem.
  2. Update readme.md file to reflect the link of the solution for the language you've selected.

rasik210 avatar Jan 14 '19 08:01 rasik210

Glad that you added readme.md but there is no thoughts section in 'solution.js' file. Can you please put that as well?

rasik210 avatar Jan 15 '19 06:01 rasik210

Thanks for adding initial thoughts section.

  • Solution passes all test cases
  • Time and space complexity are correct
  • Header is formatted properly
  • Problem has been added to README and formatted properly

@RyanFehr Can you please merge this into main repository after reviewing it from your end.

rasik210 avatar Jan 16 '19 00:01 rasik210