Ryan Cavanaugh comments

Results 613 comments of


                                            Ryan Cavanaugh

`T?` shortcut for `T | undefined`

If you're writing `x` in a parameter position, then `x: T | undefined` is almost always worse than `x?: T`. Same for properties. For local variables there's no equivalent, but...

Fix "never nullish" diagnostic missing expressions wrapped in parentheses

@typescript-bot test this @typescript-bot pack this

Closing TS 6.0 LS issues

> Maybe at least based on issue BUGs create unit tests to be sure that functionality is working? This would at best be a manual process, since the issues themselves...

Improve reverse mapped types inference by creating candidates from concrete index types

> I understand this this particular example looks complex A less complex example for novices such as myself would be appreciated, lol 😰. Something that would make sense in a...

Improve reverse mapped types inference by creating candidates from concrete index types

I asked Copilot for a summary of reverse mapped types, since I'm going to have to explain these PRs to the team. I thought it was interesting (and at least...

Improve reverse mapped types inference by creating candidates from concrete index types

Let me create a comprehensive list with samples for every PR mentioned in the history. I'll need to gather more details on the remaining PRs. Perfect! Now let me create...

Narrow destructured variables based on initializer's analysis result

@typescript-bot test it

The existence of /// reference directives in dependencies breaks explicit typeRoots ordering

I'm not quite sure what you mean by `typeRoots` ordering being different -- do you mean the order that the types directives get processed? Can you post a sample repo...

The existence of /// reference directives in dependencies breaks explicit typeRoots ordering

Your repo is just set up wrong, not sure this is an accurate bug repro. You have `src/types/node/node.d.ts`, but this isn't a valid resolution source for the `node` types directive;...

The existence of /// reference directives in dependencies breaks explicit typeRoots ordering

> TS doesn't care what the file is named in this case It does! Run `--traceResolution` and you'll see what's happening > Exactly the same thing. I'm seeing different behavior...