RxAnimated icon indicating copy to clipboard operation
RxAnimated copied to clipboard

Carthage support

Open IgorBulyga opened this issue 7 years ago • 5 comments

Added Carthage support.

Also, make some refactoring in the project hierarchy. Move project file in the root folder to produce .framework for Carthage and make Example inner target. Replace Cocoapods with Carthage for Example.

IgorBulyga avatar Nov 07 '17 12:11 IgorBulyga

Thanks @IgorBulyga, I'll have a look at the PR. I have to check out the PR locally but if you removed the development setup from the example app I'll have to reject it.

icanzilb avatar Nov 07 '17 13:11 icanzilb

@icanzilb I have merged the latest commit, where AppleTV support was added, into my PR. And provide AppleTV Framework for Carthage.

For check it out for correct work you have to run

carthage update --no-use-binaries --platform iOS,tvOS

And then just open RxAnimated.xcodeproj and run examples. Everything should be fine. If you will have any questions, I'm ready to answer them.

IgorBulyga avatar Nov 29 '17 09:11 IgorBulyga

This worked great for me in terms of Carthage support, if someone can test it with Coocapods I'd say it's mergeable.

iandundas avatar Feb 26 '18 08:02 iandundas

Hello,

Any update on this merge ? 🙂

npjk avatar Apr 09 '18 08:04 npjk

Hey guys! Would be great to merge this PR :)

Budyn avatar Jun 21 '18 13:06 Budyn