Mateusz Morusiewicz

Results 32 comments of Mateusz Morusiewicz

@mcdee > Payment transaction value fails if the builder recipient is a smart contract that transfers value (notably a splitter) Can you expand on this? The transfer doesn't have to...

A loose idea: would checking the timestamp shield the loaner from reorgs? The block timestamp post merge is deterministic and a missed or reorged out block would still make the...

Hello :) > why it doesn't work to take a snapshot of the state before applying any bundle transactions and then revert to this snapshot if any one of the...

@dmarzzz could you rebase? Sorry about that, Shapella changes got in the way.

You probably want to change this `limiter: rate.NewLimiter(rate.Every(time.Millisecond), 510),` to a second instead. Both should be configurable, either through a constant (build time) or configuration

I think it's a good idea! Keep in mind `pool.bundleFetcher` is also accessed, but it can also be covered by the bundles-specific lock.

While I love the idea, correct me if I'm wrong in thinking that a transaction can overwrite a transaction with the same nonce, removing it from the pending list. So...

> However, is it safe to assume that a transaction could only have been dropped and replaced if it had a lower gas price than the current pending transaction? Yes,...

I think it's alright The check here makes it so that only the most valuable payload makes it into the relay submission code. But all of those payloads have the...

On the other hand, why would we want to accept a block that is already a part of the chain? I will be rejected if anyone tries to propose it...