tensorboard_logger icon indicating copy to clipboard operation
tensorboard_logger copied to clipboard

Add pr-curve support

Open jeffin143 opened this issue 5 years ago • 7 comments

@RustingSword There you go

Not sure about the math, it probably looks correct but have a look at the math again :)

Changed generate_bucket() a little bit to resemble -> np.histogram()

Note : https://github.com/reminisce/tensorboard-mxnet-logger/blob/ad7d6522e4010deaa3a2a95e93629d8b01751078/tensorboardX/summary.py#L219

jeffin143 avatar Jun 27 '20 14:06 jeffin143

Just noticed, histogram support broke because of change in default_gernerate, I will try to fix it

jeffin143 avatar Jun 27 '20 14:06 jeffin143

Screenshot 2020-06-27 at 9 56 49 PM

Do you knwo how to change this value I mean, Scale it down by 1000 like 0.003 to 0..007 something like that

jeffin143 avatar Jun 27 '20 17:06 jeffin143

Do you knwo how to change this value I mean, Scale it down by 1000 like 0.003 to 0..007 something like that

I have no idea, but I think maybe it's not necessary, since reasonable PR curve won't be such a flat line.

RustingSword avatar Jun 28 '20 14:06 RustingSword

I think bucket generation still have some issues, histogram looks kind of strange now. histo

I also tested pr curve using data generated by pr curve demo code in TensorBoard repo, and the result looks different: pr

vs.

correct

I'm not sure whether I used it correctly, I'll try to find out.

RustingSword avatar Jul 05 '20 07:07 RustingSword

Ok, I will take a look again

jeffin143 avatar Jul 06 '20 04:07 jeffin143

Hi can you quickly re run the script or test

jeffin143 avatar Jul 08 '20 07:07 jeffin143

Sorry for the delay. The pr curve looks correct now, however the histogram still has some issue. I will try to find a fix.

RustingSword avatar Jul 14 '20 06:07 RustingSword