TinCanPHP icon indicating copy to clipboard operation
TinCanPHP copied to clipboard

Improving Agent and Person Code Coverage.

Open WillSkates opened this issue 9 years ago • 9 comments

WillSkates avatar Jan 27 '17 00:01 WillSkates

Seems like it's failing due to an existing error. This should be fine to merge.

WillSkates avatar Jan 27 '17 00:01 WillSkates

I can't obviously see how the latest changes would cause the tests to fail, but odd that the current master is passing.

I'd be tempted to do a fake PR of an additional code comment and see if that fails in the same way too.

garemoko avatar Jan 27 '17 08:01 garemoko

Yeah it is strange. Let me know how you get on. It may have just been that Scorm Cloud was having issues at the time. I'll reopen this to trigger the build again.

WillSkates avatar Jan 27 '17 09:01 WillSkates

Now that it's been a couple of days lets check it again.

WillSkates avatar Jan 31 '17 15:01 WillSkates

@garemoko Seems like an issue with Scorm Cloud. Is it normal to submit a ticket for this kind of thing?

WillSkates avatar Feb 02 '17 17:02 WillSkates

@WillSkates you could drop an email to [email protected]

Have you tried running the tests against another LRS?

garemoko avatar Feb 03 '17 08:02 garemoko

@garemoko I haven't. I'll try it again later tonight. Did you have any success?

WillSkates avatar Feb 03 '17 09:02 WillSkates

Apologies as I still haven't had a chance to look at this. I'll reopen to see if the issue has fixed itself.

WillSkates avatar Feb 21 '17 12:02 WillSkates

Quick google around suggests that the issue is at the other end. Looks like a java exception that's being thrown somewhere.

WillSkates avatar Feb 21 '17 12:02 WillSkates