TinCanJS icon indicating copy to clipboard operation
TinCanJS copied to clipboard

Fixed #111 -- allow the actor defined within URL configuration to be a Group.

Open frasern opened this issue 9 years ago • 2 comments

frasern avatar Jun 29 '15 17:06 frasern

Thanks for creating this. I'm sure @brianjmiller will want to review this, but just one quick comment from me: I'm personally not keen on the approach of trying to create an agent from the json and then trying group if that fails. I'd prefer to decode the object and get the objectType then try the appropriate one.

garemoko avatar Jun 29 '15 17:06 garemoko

+1 to what @garemoko said.

brianjmiller avatar Jun 29 '15 18:06 brianjmiller