password-hashes icon indicating copy to clipboard operation
password-hashes copied to clipboard

Published 20 hours ago • verified publisher icon RustCrypto

Missing algorithms

Open newpavlov opened this issue 7 years ago • 15 comments

Also see algorithms used in passlib.

newpavlov avatar Aug 16 '17 08:08 newpavlov

I have an implementation of AES KW as defined here: https://tools.ietf.org/html/rfc339, is that of interest?

dignifiedquire avatar Nov 19 '18 23:11 dignifiedquire

Does this issue mean that RustCrypto will not include bcrypt password hashing?

Or maybe there will be yet another implementation of it in this repo?

astonbitecode avatar Mar 14 '19 11:03 astonbitecode

I don't plan on doing a competing implementation without a good reason (e.g. substantial improvements/fixes which @Keats will not accept to his crate for some reason or support of hypothetical password hashing trait). Though I still would be happy to accept the crate transfer if he''ll change his mind.

newpavlov avatar Mar 14 '19 18:03 newpavlov

I can give a shot for Argon2, since there is already a Rust implementation and that RustCrypto already has Blake2. Are you still looking for someone to implement it here?

zer0x64 avatar Aug 22 '19 15:08 zer0x64

Since argon2rs has not been updated for the last 2 years and the maintainer is not answering on the ticket, what about asking the maintainer of https://github.com/sru-systems/rust-argon2 instead? It works on WASM even with multiple lanes, supports multithreading via features, supports Argon2id and is still maintained. Biggest weak point for now is the lack of SIMD.

zer0x64 avatar Feb 24 '20 21:02 zer0x64

@zer0x64 Thank you for information!

fadeevab avatar Apr 12 '20 15:04 fadeevab

For the record, one cons of all existing Argon2 implementations is a lack of no_std mode which is de-facto for RustCrypto crates. It means there is no easy way to "import" any of these crates into RustCrypto family seamlessly.

fadeevab avatar May 12 '20 20:05 fadeevab

We should definitely ping one of the existing authors to see if they want to collaborate.

Otherwise, we can fork one of the existing crates, add no_std support, and then release it as argon2.

tarcieri avatar Jun 10 '20 05:06 tarcieri

I've already pinged them in the past, see issues linked in the OP list.

newpavlov avatar Jun 10 '20 05:06 newpavlov

@newpavlov what about the maintainer of rust-argon2 as @zer0x64 mentioned?

tarcieri avatar Jun 10 '20 13:06 tarcieri

Done, see the linked issue.

newpavlov avatar Jun 10 '20 13:06 newpavlov

There is also argonautica which supports SIMD.

zizhengtai avatar Jun 17 '20 07:06 zizhengtai

We now have an argon2 crate based on the reference implementation, however it might be worth looking at reusing some code from argonautica (which is MIT/Apache2) for SIMD. See #104.

tarcieri avatar Jan 29 '21 15:01 tarcieri

We can mark Balloon (and also fix the typo) as done, see https://crates.io/crates/balloon-hash.

daxpedda avatar Mar 21 '22 18:03 daxpedda