hashes icon indicating copy to clipboard operation
hashes copied to clipboard

Port blake2 on coresimd

Open newpavlov opened this issue 7 years ago • 12 comments

With stabilization of SIMD intrinsics in Rust 1.27 we can remove simd feature from the blake2 crate.

newpavlov avatar Jun 21 '18 09:06 newpavlov

btw, here's a bounty on this issue: https://www.bountysource.com/issues/59948303-port-blake2-on-coresimd

tomtau avatar Jan 17 '19 01:01 tomtau

How would this work for rustc 1.21..=1.26?

kazcw avatar Jan 24 '19 00:01 kazcw

For v0.8 it will have to be feature-gated behind some feature (it can be the same simd feature), but I am thinking about migrating to Rust 2018 for v0.9.

newpavlov avatar Jan 24 '19 06:01 newpavlov

What about BLAKE3?

DonaldTsang avatar Feb 26 '20 05:02 DonaldTsang

I’d be very much into us having a high-performance BLAKE3 implementation but am not aware of the state-of-the-art in Rust BLAKE3 libraries /cc @zooko

tarcieri avatar Feb 26 '20 05:02 tarcieri

See BLAKE3 #103

tarcieri avatar Feb 26 '20 06:02 tarcieri

I started working on the issue.

pczarn avatar Jan 16 '23 06:01 pczarn

@pczarn it'd be really good to get #228 landed before we try to extend the current implementation

tarcieri avatar Jan 16 '23 15:01 tarcieri

@tarcieri Okay, so you are close to getting a new implementation, but a migration from core::arch x86/x86_64 intrinsics to a portable core::simd will remain to be done?

pczarn avatar Jan 17 '23 08:01 pczarn

Looks like coresimd is some internal utility, and not core::simd, so:

  • could you point me to the code for coresimd?
  • would it be better to give it a name that cannot be confused with core's simd?
  • are you looking into using core's simd once it gets stabilized?

pczarn avatar Jan 17 '23 08:01 pczarn

I think this ticket is actually referring to core::arch SIMD intrinsics, though adding support for core::simd would be nice

tarcieri avatar Jan 17 '23 14:01 tarcieri

Ok, please update me when progress with #228 happens

pczarn avatar Jan 18 '23 19:01 pczarn