formats icon indicating copy to clipboard operation
formats copied to clipboard

PKCS#7: Cryptographic Message Syntax Standard support

Open jklong opened this issue 3 years ago • 6 comments

Implement PKCS#7 per RFC5652

jklong avatar Sep 15 '21 05:09 jklong

I vote for at least adding signed_data so that the crate handles certificate sets shared as ".p7b" files.

dskyberg avatar Dec 23 '21 00:12 dskyberg

I'm happy to take a stab at SignedData support. @tarcieri would you be willing to review changes for that? 🙂

woodruffw avatar Dec 19 '22 20:12 woodruffw

In October, I had started work on decoders/encoders for CMS structs (including SignedData). I had definitions done for most structs and had started adding tests for SignedData when the shift to owned started and I paused. I could share that and/or collaborate if the timing is right for that work. I’ve not yet sussed out how much the definitions will need change, so what’s been done may or may not be a good starting point.

From: William Woodruff @.> Reply-To: RustCrypto/formats @.> Date: Monday, December 19, 2022 at 3:55 PM To: RustCrypto/formats @.> Cc: Subscribed @.> Subject: Re: [RustCrypto/formats] PKCS#7: Cryptographic Message Syntax Standard support (#28)

I'm happy to take a stab at SignedData support. @tarcieri would you be willing to review changes for that? 🙂

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.Message ID: @.***>

carl-wallace avatar Dec 19 '22 21:12 carl-wallace

I had definitions done for most structs and had started adding tests for SignedData when the shift to owned started and I paused. I could share that and/or collaborate if the timing is right for that work. I’ve not yet sussed out how much the definitions will need change, so what’s been done may or may not be a good starting point.

I'm happy to take a look, at the minimum! Collaboration would also be welcome 🙂

woodruffw avatar Dec 19 '22 21:12 woodruffw

@woodruffw I can do some cursory review but I lack expertise in PKCS#7 and it's rather complex.

@carl-wallace it'd be great if you could push up a WIP

tarcieri avatar Dec 19 '22 21:12 tarcieri

I had forgotten I was also working on CMPv2/CRMF and. I then got sidetracked with a PQC hackathon and made some mods for that mixed with the work I had been doing (notionally thinking I’d finish CMPv2 for the hackathon but did not). I checked the current state into an “as-is” branch on my fork. CMS bits are in the cms folder. I’ve not touched it since the hackathon (early November) and those bits likely need to be broken out (working CMP/CRMF/CMS in parallel seems OK). https://github.com/carl-wallace/formats/tree/as_is

From: William Woodruff @.> Reply-To: RustCrypto/formats @.> Date: Monday, December 19, 2022 at 4:47 PM To: RustCrypto/formats @.> Cc: Carl Wallace @.>, Comment @.***> Subject: Re: [RustCrypto/formats] PKCS#7: Cryptographic Message Syntax Standard support (#28)

I had definitions done for most structs and had started adding tests for SignedData when the shift to owned started and I paused. I could share that and/or collaborate if the timing is right for that work. I’ve not yet sussed out how much the definitions will need change, so what’s been done may or may not be a good starting point.

I'm happy to take a look, at the minimum! Collaboration would also be welcome 🙂

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>

carl-wallace avatar Dec 19 '22 21:12 carl-wallace

I think we can close this at this point. We've had both the now retired pkcs7 crate and its successor, the cms crate

tarcieri avatar Aug 18 '24 14:08 tarcieri