elliptic-curves icon indicating copy to clipboard operation
elliptic-curves copied to clipboard

Published 20 hours ago • verified publisher icon RustCrypto

Implement `HashToScalar` for P-384

Open daxpedda opened this issue 2 years ago • 2 comments

Depends on https://github.com/RustCrypto/traits/pull/1024.

daxpedda avatar Jun 11 '22 19:06 daxpedda

So this has to build on https://github.com/RustCrypto/traits/pull/1024 now. Considering this will be a breaking change, what's the solution here? I could just copy-paste the OSSWU code here, like we did in k256. Or should we just delay this PR? Or release an elliptic-curve 0.13-pre?

I'm in no particular hurry btw, delaying is fine with me.

daxpedda avatar Jun 13 '22 01:06 daxpedda

I think it'd probably make sense to just delay the PR until the next round of breaking changes to elliptic-curve, and in the meantime perhaps we could work out some better solutions for https://github.com/RustCrypto/traits/pull/1024 regarding the relationships between FieldElements and their inner UInts.

tarcieri avatar Jun 13 '22 14:06 tarcieri

Rebased. I guess this now depends on elliptic-curve 0.13.0-pre.0 being released.

daxpedda avatar Dec 07 '22 13:12 daxpedda

@daxpedda I'd like to get v0.12 releases of all of these crates out that move to the primeorder crate's generic implementation and bumps to signature v2.0 before upgrading elliptic-curve to v0.13.0-pre.0, since the former two are already significant changes.

That's all pretty much blocked on another release of ed25519-dalek to keep everything in sync.

tarcieri avatar Dec 07 '22 14:12 tarcieri

Alright, good to know! I'm in no rush :).

daxpedda avatar Dec 07 '22 14:12 daxpedda

Updated to https://github.com/RustCrypto/traits/commit/28ec035531ed028ba010a652980f78007c8f49ff.

EDIT: Reverted again, updating to new ff and group is a hassle we can do later.

daxpedda avatar Dec 09 '22 11:12 daxpedda

@tarcieri this is ready now.

daxpedda avatar Feb 01 '23 08:02 daxpedda