elliptic-curves icon indicating copy to clipboard operation
elliptic-curves copied to clipboard

Asymmetry in default features: only p384 has `ecdh` by default

Open hko-s opened this issue 1 year ago • 2 comments

The p384 crate differs from the other curves in that it enables the ecdh feature by default in Cargo.toml.

This is obviously not a huge deal, but I wonder if it would be good to remove it from the default features, for symmetry?

hko-s avatar May 13 '24 17:05 hko-s

Yes, it is a bit weird it's inconsistent.

Alternatively we could add ecdh to the default features of the other crates. The only drawback is the added hkdf dependency.

tarcieri avatar May 13 '24 17:05 tarcieri

I'm afraid I have no useful opinion on which way to resolve this, I just stumbled over the difference :shrug:

Personally, I'm happy either way.

hko-s avatar May 13 '24 17:05 hko-s