block-ciphers icon indicating copy to clipboard operation
block-ciphers copied to clipboard

HIGHT Cipher

Open Arul-Sujith opened this issue 11 months ago • 2 comments

  • Includes encryption and decryption functions.
  • Tested using sample vectors to ensure correctness.
  • Added Docs

Arul-Sujith avatar Feb 14 '25 19:02 Arul-Sujith

Thanks for the feedback! I’ve reviewed the structure of other implementations in the repository. I’ll restructure and update the PR soon. Let me know if there are any specific guidelines I should follow!

Arul-Sujith avatar Feb 14 '25 21:02 Arul-Sujith

You haven't matched the format of other block cipher crates. At the very least you have to implement the cipher traits. The docs folder is also not necessary a link to the HIGHT paper in crate docs will be sufficient.

You also need to add a CI config for the crate and add it to the workspace (see the root Cargo.toml).

newpavlov avatar Mar 10 '25 11:03 newpavlov