block-ciphers icon indicating copy to clipboard operation
block-ciphers copied to clipboard

Missing feature flag

Open ShaneMurphy2 opened this issue 3 years ago • 4 comments

The crate aes has code conditionally disabled behind the feature aes_armv8, but that feature was removed from Cargo.toml here. Furthermore, the crate aes_gcm, also maintained by RustCrypto though not part of this repository, does not expose a feature to pass though to its dependency on aes. In addition, the documentation for aes still refer to this feature, so either way I'm a bit lost.

I'm trying to build aes_gcm using the armv8 crypto extensions, but for the reasons mentioned I don't see how.

Apologies if I'm missing something obvious, thanks!

ShaneMurphy2 avatar Sep 16 '22 00:09 ShaneMurphy2

The ARM backend is now enabled using configuration flags as described here. It seems we forgot to remove mention of removed features in the rest of docs.

newpavlov avatar Sep 16 '22 00:09 newpavlov

Ah, I didn't scroll to the bottom before diving down the feature flag dependency chain. Is the reason for using a configuration option over a feature flags so that there doesn't need to be a chain of feature flags all the way to the aes crate?

ShaneMurphy2 avatar Sep 16 '22 16:09 ShaneMurphy2

See https://github.com/RustCrypto/block-ciphers/issues/245 for discussion which led to the change.

newpavlov avatar Sep 16 '22 16:09 newpavlov

Interesting discussion, all good now. Thanks!

ShaneMurphy2 avatar Sep 16 '22 16:09 ShaneMurphy2