block-ciphers icon indicating copy to clipboard operation
block-ciphers copied to clipboard

ParBlocksSizeUser impls

Open rozbb opened this issue 2 years ago • 4 comments

This impls ParBlocksSizeUser for AES and Kuznyechik block ciphers. ParBlocksSizeUser was already impl'd for their backends, so this was a matter of copy-pasting.

This unblocks the fix for https://github.com/RustCrypto/AEADs/issues/410

rozbb avatar Apr 29 '22 08:04 rozbb

No, it's meaningless to implement ParBlocksSizeUser on ciphers themselves. If you need access to explicit parallel block processing, then you SHOULD use the with_backend methods.

newpavlov avatar Apr 29 '22 11:04 newpavlov

@newpavlov can you take a look at https://github.com/RustCrypto/AEADs/issues/410 ?

None of us can figure out how to properly do the upgrade.

tarcieri avatar Apr 29 '22 13:04 tarcieri

@tarcieri Yes, I will try to do it this weekend.

newpavlov avatar Apr 29 '22 13:04 newpavlov

Hi @newpavlov, a gentle nudge on this. Or would you need any help?

tomtau avatar May 26 '22 09:05 tomtau

Seems this is not necessary

tarcieri avatar Aug 25 '22 21:08 tarcieri