rust-jack icon indicating copy to clipboard operation
rust-jack copied to clipboard

best effort close client

Open srperens opened this issue 6 months ago • 1 comments

Remove assert that connection closing is successful.

If the jack server is shutdown/restarted while the client connection is up then the closing will fail and you get a thread panic from the assert.

Furthermore the whole client is forever "bricked" since the assert will happen while holding the CREATE_OR_DESTROY_CLIENT_MUTEX.lock(). The mutex will get a PoisonError which prevents a new client connection to be created again. The mutex is a lazy_static "singleton" so it prevents ANY client to be created for the duration of the application.

srperens avatar Dec 22 '23 08:12 srperens