rodio icon indicating copy to clipboard operation
rodio copied to clipboard

chore: update cpal to latest Git, fix conflict

Open philpax opened this issue 2 months ago • 5 comments

This PR is a prospective update of the cpal dependency to the latest Git version. It is not intended to be merged (at least until the next cpal release is cut); instead, it's intended as a version of rodio that can have its cpal patched with a fork of the ~current cpal HEAD (e.g. my https://github.com/RustAudio/cpal/pull/1027).

The only changes so far:

  • running cargo update -p objc2 to break a dependency resolution conflict
  • replacing From<Input> for cpal::Device with Input::into_inner, as cpal now has a conflicting trait implementation. ~~I considered implementing Into, but the asymmetry of not having the From is generally frowned upon.~~ (the From blanket impl blocks this)
  • enables U24 support
  • removes the cpal-shared-stdcxx feature, which activates the oboe backend for cpal, which has since been removed

philpax avatar Oct 01 '25 18:10 philpax

Thanks for this preparatory work. Now that https://github.com/RustAudio/cpal/pull/1011 is merged, we can also enable the U24 sample format in stream.rs and microphone.rs.

roderickvd avatar Oct 13 '25 19:10 roderickvd

Done and updated to the latest cpal 🙂

philpax avatar Oct 14 '25 12:10 philpax

I'd like to release v0.17 soon. call for final testing! https://github.com/RustAudio/cpal/pull/1065

roderickvd avatar Dec 08 '25 21:12 roderickvd

I'm currently on holiday and can't update my PRs, but that seems fine at a glance! Feel free to use this PR / close it / do whatever you need to :slightly_smiling_face:

philpax avatar Dec 10 '25 01:12 philpax

Updated it to latest cpal master.

roderickvd avatar Dec 10 '25 14:12 roderickvd

Just released cpal v0.1.70. Updating this PR to match and merging when the CI passes.

roderickvd avatar Dec 20 '25 19:12 roderickvd