rodio icon indicating copy to clipboard operation
rodio copied to clipboard

skip duration breaks span len

Open yara-blue opened this issue 11 months ago • 3 comments

Skip duration does not take span len into account. It might return samples for a different sample rate and channel count while its parent/wrapper still thinks its in the same span.

Solution: It should probably pad the current frame with silence if the sample rate and/or channel count do not match after skip.

yara-blue avatar Jan 23 '25 15:01 yara-blue

alternative is to make the queue handle this... might be easier to have all the complexity in one spot.

yara-blue avatar Jan 23 '25 16:01 yara-blue

closing, handling in queue, behavior is fine by rodio's Source trait

yara-blue avatar Jan 23 '25 16:01 yara-blue

actually still broken, sample rate might have changed while skipping. Consumer will assume its still the same. No way to let Consumer know...

Need to inject silence OR figure out a way to communicate span change to consumer....

yara-blue avatar Jan 23 '25 16:01 yara-blue