rodio icon indicating copy to clipboard operation
rodio copied to clipboard

Add resample example

Open wiccy46 opened this issue 2 years ago • 1 comments

The documentation is not obvious regarding how to resample an input.

wiccy46 avatar Aug 15 '23 16:08 wiccy46

The sink will resample input for you when you append see: https://github.com/RustAudio/rodio/blob/818f557466098942e7b928ca6c7d696bc786207c/src/sink.rs#L150

This example is therefore resampling twice (once using UniformSourceIterator explicit and once implicit in sink). That does not make sense right?

A PR clarifying the docs for Sink::append might be a better way to address this. Cause I do agree it is very confusing and not obvious how input is resampled! Please, if you are willing, help improve the docs, we could really use the help.

yara-blue avatar Apr 10 '24 10:04 yara-blue