rodio
rodio copied to clipboard
[WIP] feat: playing sound from remote source
WIP
run --example http_flac --features=https-rustls
is already working
Hey, sorry for my late, I was focused on another project.
In fact this PR is already pretty stable... Except when the size of the sound is too heavy for our bandwidth. In that case, the sound may cut until the next block is downloaded, but I do not see a better way to handle it. Should we wait until N blocks are downloaded? When N may vary with sizeOfFile / downloadSpeed.
Do we need some unit test or just a cargo fmt
will be enough?
I don't really want global cargo fmt to be run that changes all of rodio's source code, especially not in a PR that changes functional things. That way, you can't really inspect the changes any more.
You are already now changing the formatting of files unrelated to the PR.
Can you maybe file a separate PR, find stable alternatives to the rustfmt options present and then run cargo fmt?
Also I'm not 100% convinced that this PR fits in the scope of rodio, as downloading might be done by games rather at the asset layer.