cpal icon indicating copy to clipboard operation
cpal copied to clipboard

Deduplicate parking_lot dependency

Open alice-i-cecile opened this issue 3 years ago • 4 comments

The Cargo.toml depends on two different versions of parking_lot, depending on which platform is used.

If possible, these should be synchronized to 0.12.

This came up in the context of https://github.com/bevyengine/bevy/pull/3825. Over at Bevy, we rely on cpal and try to avoid duplicate versions of crates in our dependencies to improve compile speeds and executable size.

alice-i-cecile avatar May 17 '22 23:05 alice-i-cecile

PRs welcome!

est31 avatar May 21 '22 20:05 est31

For some reason I'm getting a 500 error when trying to view the diff, but I believe this has been fixed via #644.

TimJentzsch avatar Aug 13 '22 21:08 TimJentzsch

(As far as I can see, this PR hasn't been released yet, so the issue on Bevy's side is not yet fixed)

TimJentzsch avatar Aug 13 '22 22:08 TimJentzsch

Yeah it seems the github account that made that PR was deleted and thus there are 500 errors. A new release would be good. Need to check whether it is a semver breaking one.

est31 avatar Aug 14 '22 21:08 est31