cpal icon indicating copy to clipboard operation
cpal copied to clipboard

RUSTSEC-2020-0056: stdweb: stdweb is unmaintained

Open brightly-salty opened this issue 5 years ago • 5 comments

The stdweb crate is unmaintained, as recorded by this RustSec advisory. Here is the reference issue.

Maintained alternatives include wasm-bindgen, js-sys, and web-sys.

I'm willing to look into this and see how difficult it is. I'm also willing to attempt it and open a pull request if it would be accepted.

brightly-salty avatar Dec 07 '20 17:12 brightly-salty

Thanks for letting us know and for opening this! A PR addressing this would be more than welcome :)

mitchmindtree avatar Dec 08 '20 16:12 mitchmindtree

Almost everything's done, but I'm having a bit of trouble with emscripten::audio_callback_fn. It needs to be a static closure (among other things) to be able to convert into Js Function, but currently it is taking variables from Device::build_output_stream_raw(). Any ideas on how to refactor it to make it work?

brightly-salty avatar Dec 11 '20 02:12 brightly-salty

Any update? PR is almost 1 year old without any comments or reviews

qarmin avatar Nov 14 '21 09:11 qarmin

Yeah, seems stdweb is dead. It would be nice if someone could rebase the PR and file a new one with the rebased changes (or @brightly-salty does it in their PR).

est31 avatar Nov 14 '21 12:11 est31

sure, I can try. I don't think I was ever able to get that closure issue working though.

brightly-salty avatar Nov 14 '21 15:11 brightly-salty