coreaudio-sys icon indicating copy to clipboard operation
coreaudio-sys copied to clipboard

Build Fails In Sonoma 14.5

Open ElessaR-x opened this issue 1 year ago • 4 comments

Build fails with this message:

error: expected one of `!` or `::`, found keyword `static`
 --> /Users/ardaozger/Desktop/mythmallow/target/debug/build/coreaudio-sys-81a18b91c2ba4bef/out/coreaudio.rs:3:11
  |
3 | rewriting static
  |           ^^^^^^ expected one of `!` or `::`

Rust Version: cargo 1.81.0-nightly (bc89bffa5 2024-06-22)

coreaudio-sys version: V0.2.15

macOS version: Sonoma 14.5 (23F79)

ElessaR-x avatar Jun 24 '24 16:06 ElessaR-x

Started getting this as well in github CI:

https://github.com/lukexor/tetanes/actions/runs/9647882987/job/26607742318

Current runner version: '2.317.0' Operating System macOS 14.5 23F79 Runner Image Image: macos-14-arm64 Version: 20240616.1 Included Software: https://github.com/actions/runner-images/blob/macos-14-arm64/20240616.1/images/macos/macos-14-arm64-Readme.md Image Release: https://github.com/actions/runner-images/releases/tag/macos-14-arm64%2F20240616.1

rust 1.81.0-nightly (bcf94dec5 2024-06-23)

Was fine in the previous version:

Current runner version: '2.317.0' Operating System macOS 14.5 23F79 Runner Image Image: macos-14-arm64 Version: 20240611.1 Included Software: https://github.com/actions/runner-images/blob/macos-14-arm64/20240611.1/images/macos/macos-14-arm64-Readme.md Image Release: https://github.com/actions/runner-images/releases/tag/macos-14-arm64%2F20240611.1

rust rustc 1.81.0-nightly (d7f6ebace 2024-06-16)

lukexor avatar Jun 25 '24 00:06 lukexor

And it's not limited to just macOS 14.5

I get the same error on macOS 12.6 with rust 1.81.0-nightly (bcf94dec5 2024-06-23)

So this appears to be due to a Rust nightly update, not specifically macOS Sonoma.

lukexor avatar Jun 25 '24 00:06 lukexor

Seems due to this? https://github.com/rust-lang/rustfmt/issues/6210 and https://github.com/rust-lang/rust-bindgen/issues/2852

lukexor avatar Jun 25 '24 04:06 lukexor

I've been afk for a few days and just saw this. Looks like the rustfmt fix landed and this isn't an issue anymore (it doesn't repro for me on nightly). Let me know if there are changes to coreaudio-sys needed if it's still an issue.

simlay avatar Jun 27 '24 16:06 simlay