rust-pip icon indicating copy to clipboard operation
rust-pip copied to clipboard

Published 20 hours ago • verified publisher icon Rust-Python-Packaging

Add a CI job to ensure that `CHANGELOG` is updating in a PR

Open John15321 opened this issue 2 years ago • 1 comments

Add a Ci job that would check that the CHANGELOG file has gotten updated with a given Pull Request. A simple git diff between the feature branch and the target branch will be enough.

Blocked by:

  • https://github.com/John15321/rust-pip/issues/32

John15321 avatar Aug 15 '22 21:08 John15321

Personally, I think this is kind of a pain. There are tons of PRs that really don't need a changelog entry. Even if you relied on a maintainer adding some sort of a "skip news" label, that takes a while and causes CI to fail for little reason.

I think that it's enough to add it to the PR template and reviewers can check if the PR needs it.

dawnofmidnight avatar Sep 04 '22 16:09 dawnofmidnight