gccrs icon indicating copy to clipboard operation
gccrs copied to clipboard

Add check for token at parse_bare_function_type

Open lucbf opened this issue 1 month ago • 4 comments

previously the compiler emmited:

expecting ‘(’ but ‘identifier’ found

now it emmits:

unexpected token 'identifier' - expected bare function

code example:

impl Foo for
fn my_function() {
//do something
}

lucbf avatar Nov 28 '25 13:11 lucbf

Not sure if I'm doing things right, but I had to delete my previous branch to rebase to the current gccrs

lucbf avatar Nov 28 '25 13:11 lucbf

Not sure if I'm doing things right, but I had to delete my previous branch to rebase to the current gccrs

No this doesn't feel right. You don't have to delete anything to rebase your work on top of master. If you maintain a master branch on your fork then you can simply fetch it from the main repository and rebase it, either with your local git or online using the "sync fork" button.

P-E-P avatar Nov 28 '25 13:11 P-E-P

I pushed the button and suddenly all the compiler checks failed, but I guess I could just delete my local branch

lucbf avatar Nov 28 '25 13:11 lucbf

Alpine build couldn't run properly because It couldn't download gettext-0.22.tar.gz

lucbf avatar Nov 28 '25 18:11 lucbf

Looks like there are some merge conflicts with #4322, which split rust-parse-impl.h into separate files. You'll probably have to manually move your changes into the file that parse_bare_function_type was moved into.

powerboat9 avatar Dec 14 '25 19:12 powerboat9

Looks like there are some merge conflicts with #4322, which split rust-parse-impl.h into separate files. You'll probably have to manually move your changes into the file that parse_bare_function_type was moved into.

There shouldn't be too many conflicts because I specifically left type parsing in the main file to avoid conflicts with this PR. Hopefully this won't be too hard @lucbf , if you need any help, please shout!

P-E-P avatar Dec 15 '25 12:12 P-E-P