gccrs icon indicating copy to clipboard operation
gccrs copied to clipboard

Fixed #2500

Open zhanghe9702 opened this issue 11 months ago • 3 comments

Add a seperate typecheck pass collect impl blocks, then report errors.

Signed-off-by: Zhang He [email protected]

ChangLog:

    * gcc/rust/typecheck/rust-hir-inherent-impl-check.h: new typecheck pass
    * gcc/rust/typecheck/rust-hir-type-check.cc: modify the function which test primitive type
    * gcc/rust/typecheck/rust-tyty.cc: the new typecheck pass entrypoint
    * gcc/testsuite/rust/compile/issue-2500-rustc.rs: testsuite case same with rustc
    * gcc/testsuite/rust/compile/issue-2500.rs: testsuite case

Thank you for making Rust GCC better!

If your PR fixes an issue, you can add "Fixes #issue_number" into this PR description and the git commit message. This way the issue will be automatically closed when your PR is merged. If your change addresses an issue but does not fully fix it please mark it as "Addresses #issue_number" in the git commit message.

Here is a checklist to help you with your PR.

  • [ ] GCC development requires copyright assignment or the Developer's Certificate of Origin sign-off, see https://gcc.gnu.org/contribute.html or https://gcc.gnu.org/dco.html
  • [ ] Read contributing guidlines
  • [ ] make check-rust passes locally
  • [ ] Run clang-format
  • [ ] Added any relevant test cases to gcc/testsuite/rust/

Note that you can skip the above if you are just opening a WIP PR in order to get feedback.

*Please write a comment explaining your change. This is the message that will be part of the merge commit.

zhanghe9702 avatar Jan 28 '25 07:01 zhanghe9702

make check-rust pass at local machine, i will fix code format tomorrow

zhanghe9702 avatar Jan 31 '25 15:01 zhanghe9702

I fixed the formatting and rebased the PR. if reviewers are happy with the changes we should merge this :)

CohenArthur avatar Jun 12 '25 13:06 CohenArthur

I fixed the formatting and rebased the PR. if reviewers are happy with the changes we should merge this :)

would it make sense to squash both commits?

dkm avatar Jun 12 '25 14:06 dkm