Cleanup vector copies from Rust to C++ in BIR

Open CohenArthur opened this issue 1 year ago • 2 comments

Perform a simple copy/move from the FFIVector type to an std::vector instead of manually copying and deleting the old memory. This is low priority and should be addressed later.

Jun 24 '24 13:06 CohenArthur

currently we are copying data from FFIVector<Pair<size_t, FFIVector<size_t> *>> to std::vector<std::pair<size_t, std::vector<size_t>>>

not sure how we can "move" that

Jul 05 '24 11:07 braw-lee

This issue is related to this comment: https://github.com/Rust-GCC/gccrs/pull/3058#discussion_r1651013422

(might be invalid - I'll investigate it this week)

Jul 05 '24 12:07 CohenArthur