gccrs icon indicating copy to clipboard operation
gccrs copied to clipboard
verified publisher icon Rust-GCC

Reduce the amount of raw pointer the HIR API

Open P-E-P opened this issue 1 year ago • 2 comments

This draft PR is a first attempt at reducing the amount of raw pointers in the HIR API by replacing those either with references or smart pointers.

Requires #2867 to be merged first.

This PR probably requires a lot of other changes, I was trying to get something that compiles again quickly and many things may be wrong.

@philberty Is this even something you'd like to see merged ?

P-E-P avatar Feb 27 '24 12:02 P-E-P

I think this is a good idea, I did alot of hacky stuff in the HIR just to get stuff going but yeah this was lazy of me. If you can i would persue finishing this PR

philberty avatar Sep 27 '24 11:09 philberty

It's been a long time since I last updated this PR. This was compiling fine but there was a lot of errors (mainly use after free and segfaults). So even if we manage to rebase it on master it'll still be a long way until merge.

I put you as reviewer because the HIR is mostly your work and I didn't want to bring huge change that you would disagree with.

P-E-P avatar Sep 30 '24 08:09 P-E-P

This does not look good, I should have refactored the hir files before attempting to remove the raw pointers.

P-E-P avatar Oct 21 '24 14:10 P-E-P

Putting this as ready as it will be horrible and long to review, it still requires a few fixes and a rebase though.

P-E-P avatar Nov 12 '24 10:11 P-E-P