gccrs icon indicating copy to clipboard operation
gccrs copied to clipboard

testsuite: Fix missing handling of little endian.

Open CohenArthur opened this issue 1 year ago • 3 comments

Some failures occur in the testsuite because we did not account for the big-endian case.

gcc/testsuite/ChangeLog:

* rust/compile/issue-1446.rs: Add swap_bytes function.
* rust/compile/iterators1.rs: Remove unused {to, from}_le functions.

Before merging this I would like to run our testsuite on the compile farm on a SPARC machine to see that they're really fixed. Will report here once it's done.

CohenArthur avatar Jan 18 '24 20:01 CohenArthur

I can give you SSH to our beefy sparc machine (just email me an SSH key + desired username). It needs kicking for a reboot every so often but it's fine otherwise.

It's the same machine used for the sourceware buildbot.

thesamesam avatar Jan 20 '24 11:01 thesamesam

thanks @thesamesam I appreciate it a lot :) I've tested these changes on one of the machines of the GCC compile farm but I'll definitely take you up on that offer :D I'll email you!

CohenArthur avatar Jan 23 '24 16:01 CohenArthur

not sure why this causes a regression on MacOS. I'll ssh into the machine and investigate later

CohenArthur avatar Jan 26 '24 12:01 CohenArthur