gccrs icon indicating copy to clipboard operation
gccrs copied to clipboard

Update libgrust for upstream GCC commit 6a6d3817afa02bbcd2388c8e005da6faf88932f1 "Config,Darwin: Allow for configuring Darwin to use embedded runpath"

Open tschwinge opened this issue 2 years ago • 3 comments

I suppose that once upstream GCC commit 6a6d3817afa02bbcd2388c8e005da6faf88932f1 "Config,Darwin: Allow for configuring Darwin to use embedded runpath" is merged in (I'm planning to work on that soonish), libgrust needs to be updated accordingly?

As a corollary, if libgrust is pushed into GCC upstream, it needs to be updated accordingly, too (before the git push)?

tschwinge avatar Oct 24 '23 15:10 tschwinge

do you think that commit will be merged soon? also, interesting to see that the actual commit was authored in March 2021 :)

CohenArthur avatar Oct 24 '23 16:10 CohenArthur

@CohenArthur:

do you think that commit will be merged soon?

Sorry if what I wrote was ambiguous: I meant to say: "once upstream GCC commit [...] is merged [into GCC/Rust master branch] (I'm planning to work on that soonish)".

That GCC commit 6a6d3817afa02bbcd2388c8e005da6faf88932f1 "Config,Darwin: Allow for configuring Darwin to use embedded runpath" already is in GCC upstream, and therefore I presume https://inbox.sourceware.org/[email protected] "libgrust: Add libproc_macro and build system" needs to be adjusted accordingly, in order to not break Darwin? (@iains?) Should be easy to do.

also, interesting to see that the actual commit was authored in March 2021 :)

Well, that happens... :-)

tschwinge avatar Oct 25 '23 21:10 tschwinge

missing the change for Darwin would probably not break bootstrap - what it would do is to embed a fixed runpath (/prefix/lib) instead of @rpath/ .. but, yes, we should make the corresponding change - copying what is done elsewhere should work.

iains avatar Oct 25 '23 22:10 iains