Noriben icon indicating copy to clipboard operation
Noriben copied to clipboard

hashlist and csv creation issues

Open phate1 opened this issue 1 year ago • 1 comments

Hey

Just loaded this up today and hit a few snags at first.

Kept getting errors about not being able to open the PML for reading found that it was trying to read the file before the first process had fully terminated and released it. solved that on my side simply enough by adding a 30 second sleep timer to process_pml_to_csv maybe my VM is exceptionally slow? There is probably a better fix, but it was a quick plaster

I also had issues with adding the hash list in read_hash_file function looks like the csv reader line was updated a few months back to: reader = csv.DictReader(hash_file_handle)

but later code is still expecting a list:

hashval = hash_line[0]

Again quick fix for me just changed it back to:

csv.reader(hash_file_handle)

thanks

phate1 avatar May 12 '23 14:05 phate1

Thank you! The CSV change was a bug in a recent update. The update had meant to only change the csv reading method for the event file, but not for hash list. You're right, it should have used the original method. I've changed it back.

For the first, there may be a performance issue. A fix could potentially be just checking if it has an open file handle and then waiting until the handle is released. Can you provide the error messages? Are they IOError errors?

Rurik avatar May 12 '23 15:05 Rurik

Please reopen if there is more to add. Thanks!

Rurik avatar Sep 06 '24 17:09 Rurik