DiffusionToolkit icon indicating copy to clipboard operation
DiffusionToolkit copied to clipboard

[BUG] Ignore 'System Volume Information' anywhere it might appear

Open richardm1 opened this issue 1 year ago • 3 comments

Describe the bug My Stable Diffusion setup includes three different disk volumes mounted to empty folders on a single filesystem. In the *nix world this is called Tuesday but in Windows it's strange and exotic and it uncovers unexpected application behavior once in a while. One side effect of this setup is apps will encounter System Volume Information in locations other than the volume's root.

DiffusionToolkit encounters System Volume Information in a non-root location, throws an error, then exits:

image

Repair requires hand editing config.json to remove the offending path.

Version: 1.7.0

To Reproduce Mount a disk volume to an empty folder:

{9F8AAE8A-F896-41E3-A081-B04BC147854C}

Launch DiffusionToolkit; configure it to scan this path:

{C79257FA-E48E-4E33-A056-F96FF075B700}

image

Expected behavior No crashy-crashy; no errors.

Workaround ~~Manually exclude System Volume Information from scanning.~~ The scan for SD Models (which does not have a user-selectable folder exclusion) will also trigger this bug.

richardm1 avatar Sep 25 '24 21:09 richardm1

Also discovered the scan for models/checkpoints will error out on System Volume Information if any root folder is specified in the Model Root field. In other words, it chokes on System Volume Information appearing in its usual location in addition to unusual locations. 😉

richardm1 avatar Sep 25 '24 21:09 richardm1

That folder is protected, you can't access it. You will also have a problem with the Recycle Bin (which you can access but you shouldn't). The solution is simple, don't map the root of a drive, and put the content in a folder. Also, you probably should be using junctions instead of mapping drives that way.

However, DiffusionToolkit should probably be changed to ignore hidden files.

acorderob avatar Oct 20 '24 08:10 acorderob

These are not "mappings"; they are mounts. The underlying technology is reparse points which are common to both junctions and symbolic links. Regardless, programs shouldn't be choking on folders with both hidden and system attributes. Those two folders are marked as such for a reason and there's no reason why userspace software shouldn't be oblivious to their presence.

richardm1 avatar Oct 20 '24 17:10 richardm1