omr-agentcore

omr-agentcore copied to clipboard

Fix to avoid intermittent crashes while shutdown on zos

4

While processLoop is running don't destruct the threads too early on zos and windows to avoid intermittent crashes. Fixes #102 Signed-off-by: Ravali Yatham \

yathamravali

Intermittent z/OS crash in libhealthenter.so when stopping while invoking JNI calls

1

StackTrace of abort: ``` 27 JNIEnv_::GetStaticMethodID(_jclass*,const char*,const char*) +00000054 *PATHNAM 28 ibmras::monitoring::plugins::j9::getMXBean(JNIEnv_*,_jclass* +00000250 *PATHNAM 29 ibmras::monitoring::plugins::j9::cpu::CpuPlugin::pullInt() +0000080C *PATHNAM 30 ibmras::monitoring::plugins::j9::cpu::pullWrapper() +00000054 *PATHNAM 31 ibmras::monitoring::agent::threads::WorkerThread::processLoop +000001EE *PATHNAM 32 ibmras::monitoring::agent::threads::WorkerThread::threadEntry ``` Assembly...

yathamravali

Intermittent z/OS crash in libhealthenter.so when stopping

3

IPCS `ip verbx ledata 'nthreads(*)'` shows a crash in `WorkerThread::processLoop`: ``` 18 abort HLE77C0:edcabort.c 19 masterSynchSignalHandler j20200901 20 __zerro HLE77C0:edczerro.c 21 __zerros HLE77C0:edczerro.c 27 ** NoName **.......................c..F....-....WorkerThread.cpp... 28 ** NoName...

kgibm

This `enum LOG_LEVELS` declaration also included a _variable name_, causing https://github.com/RuntimeTools/appmetrics/issues/641. It ended up defining a `Log_levels` variable in every compilation unit that included "Log.h", which then caused duplicate symbols...

goto-bus-stop

z/OS specific: Semaphores are now based on IPC keys, which require a backing file system to generate unique identifiers. Currently the place to create that backing file system, named `.com_ibm_tools_hc`,...

mattcolegate

I installed appmetrics on node v10 in windows 10 and I always receive the following error: com.ibm.diagnostics.healthcenter.plugins WARNING: [cpu_os] At least one data I tried to check the error, put...

jhondavila

Check return value of getcwd()

1

I noticed the following compiler warning: ``` ../omr-agentcore/src/ibmras/monitoring/connector/headless/HLConnector.cpp: In member function 'void ibmras::monitoring::connector::headless::HLConnector::startNewTempDir()': ../omr-agentcore/src/ibmras/monitoring/connector/headless/HLConnector.cpp:206:40: warning: ignoring return value of 'char* getcwd(char*, size_t)', declared with attribute warn_unused_result [-Wunused-result] getcwd(cDirectory, sizeof(cDirectory)); ```...

bnoordhuis

Replace semaphore with a state flag on zos

1

This change is to avoid semaphore contention across multiple processes. Currently on ZOS for each of the seven HC threads a unique semaphore ID will be created and are reused...

yathamravali

Replace semaphore with mutex on zos

1

This change is to avoid semaphore contention across multiple processes. Currently on ZOS for each of the seven HC threads a unique semaphore ID will be created and are reused...

sharanpatil123