appmetrics icon indicating copy to clipboard operation
appmetrics copied to clipboard

added couchbase probe.

Open jakewarr8 opened this issue 8 years ago • 4 comments
trafficstars

#494

I created a new PR with a cleaner commit history.

jakewarr8 avatar Nov 22 '17 18:11 jakewarr8

@sjanuary Hi. I reopened a new PR with a cleaner commit log and the changes you wanted. Thanks for the help. Let me know if anything else needs changed.

jakewarr8 avatar Nov 22 '17 18:11 jakewarr8

Codecov Report

Merging #506 into master will decrease coverage by 0.35%. The diff coverage is 29.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #506      +/-   ##
==========================================
- Coverage    60.8%   60.45%   -0.36%     
==========================================
  Files          49       50       +1     
  Lines        3215     3252      +37     
==========================================
+ Hits         1955     1966      +11     
- Misses       1260     1286      +26
Impacted Files Coverage Δ
probes/couchbase-probe.js 29.72% <29.72%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d702f6e...9417b03. Read the comment docs.

codecov-io avatar Nov 22 '17 18:11 codecov-io

This is looking good to me, we just need to find the time to try it out ourselves, but we do aim to get this merged (might be after Christmas)

sjanuary avatar Nov 29 '17 09:11 sjanuary

Hello,

Any news from this merge?

blackrez avatar Mar 16 '18 15:03 blackrez