RunestoneComponents icon indicating copy to clipboard operation
RunestoneComponents copied to clipboard

Issue #1294

Open campbelle2 opened this issue 2 years ago • 6 comments

This is the code we had when the code auto-completion began, but we are not sure why. If you figure it out or need us to change anything just let us know

campbelle2 avatar Aug 02 '22 13:08 campbelle2

I looks like there are a few pieces missing? I don't see where you have defined the keywords?

bnmnetp avatar Aug 03 '22 16:08 bnmnetp

I see what you mean @bnmnetp . The file with the keywords is in the node_modules directory but I cannot view that directory on GitHib. Could it be something with that folder not appearing properly?

campbelle2 avatar Aug 03 '22 16:08 campbelle2

I think you need to add it locally and push to github.

bnmnetp avatar Aug 03 '22 17:08 bnmnetp

None of the changes I make in the node_modules folder appear in the source control tab of VS code so I cannot commit them. Do I need to do something specific to commit changes from that folder?

campbelle2 avatar Aug 03 '22 17:08 campbelle2

The node_modules folder is ignored. Those are all installed automatically based on the contents of the package.json file when you run npm install. In other words, those are third party libraries that you should not be modifying.

If you added files then you can move them to activecode/js and import them there. If you modified other files I would be curious to know which ones.... There should be a way to do this without modifying third party libraries directly.

bnmnetp avatar Aug 03 '22 19:08 bnmnetp

All of the other modes/keyword banks for the CodeMirror autocompletion were in that folder so I assumed this one needed to be as well. The current import for the java mode in activecode.js is codemirror/mode/java so that may need to be changed if the java.js file needs to be outside node_modules.

campbelle2 avatar Aug 03 '22 19:08 campbelle2