flux
flux copied to clipboard
FluxOs Sentinel
https://docs.google.com/document/d/1LHCyvZTkuGTe5CSUSEAdY77dKJWlxZc-Y16KCXTyGpM/edit
Codecov Report
Attention: 343 lines
in your changes are missing coverage. Please review.
Comparison is base (
dbf1b27
) 52.78% compared to head (55daa5e
) 51.58%. Report is 216 commits behind head on development.
Additional details and impacted files
@@ Coverage Diff @@
## development #1144 +/- ##
===============================================
- Coverage 52.78% 51.58% -1.21%
===============================================
Files 42 42
Lines 13285 13639 +354
===============================================
+ Hits 7013 7035 +22
- Misses 6272 6604 +332
Files | Coverage Δ | |
---|---|---|
ZelBack/src/services/fluxNetworkHelper.js | 59.67% <ø> (ø) |
|
ZelBack/src/services/dbHelper.js | 87.50% <0.00%> (-3.81%) |
:arrow_down: |
ZelBack/src/services/explorerService.js | 71.37% <55.55%> (-0.18%) |
:arrow_down: |
ZelBack/src/services/fluxCommunication.js | 44.16% <9.61%> (-4.20%) |
:arrow_down: |
ZelBack/src/services/fluxService.js | 73.37% <6.61%> (-14.96%) |
:arrow_down: |
ZelBack/src/services/appsService.js | 25.68% <2.20%> (-0.76%) |
:arrow_down: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
We should make sure that the new code has test coverage as much as possible
Yes, I agree, I will write a xls with the tests that we should do before even merging to development. For now is more like for code review...
Great job! We also need to write proper test suite for these changes as well