aqueduct icon indicating copy to clipboard operation
aqueduct copied to clipboard

ENG-1452-remove base64 encoding for artifact results when calling preview response

Open Boyuan-Deng opened this issue 3 years ago • 2 comments

Describe your changes and why you are making these changes

remove the unnecessary steps of converting bytes array to base64 string in the preview response route After the code change, in the preview response route, the backend will package the artifact_results as a byte array and send in a multipart-data-form format as a response and being correctly received by the sdk as a post response.

Related issue number (if any)

Checklist before requesting a review

  • [ ] I have created a descriptive PR title. The PR title should complete the sentence "This PR...".
  • [ ] I have performed a self-review of my code.
  • [ ] I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
  • [ ] If this is a new feature, I have added unit tests and integration tests.
  • [ ] I have run the integration tests locally and they are passing.
  • [ ] I have run the linter script locally (See python3 scripts/run_linters.py -h for usage).
  • [ ] All features on the UI continue to work correctly.
  • [ ] Added one of the following CI labels:
    • run_integration_test: Runs integration tests
    • skip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)

Boyuan-Deng avatar Aug 08 '22 21:08 Boyuan-Deng

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@cw75 would appreciate another review when you got a chance

Boyuan-Deng avatar Aug 15 '22 19:08 Boyuan-Deng

@Boyuan-Deng could you do a rebase against main? Then I'll take a final look and let's merge this in.

cw75 avatar Aug 18 '22 07:08 cw75

@Boyuan-Deng could you do a rebase against main? Then I'll take a final look and let's merge this in.

feel free to take a final look

Boyuan-Deng avatar Aug 19 '22 02:08 Boyuan-Deng

After communication, @cw75 will test with lazy execution before merging it.

Boyuan-Deng avatar Aug 29 '22 16:08 Boyuan-Deng