Michael Schmidt
Michael Schmidt
This has been fixed by #2683. I know this because a dep just failed to install for me, and everything worked out fine.
Huh. Then could please attach your logs?
Cannot reproduce. I just tested your code on `main` and the function returns `void` as expected (in JS and in the type definitions). So this is probably an issue with...
Now I understand what's going on here. Rust 1.82 enabled multivalue returns by default (related #4133). This allows wasm-bindgen to directly return multiple value instead of using a return pointer....
> It is an issue because the type signature in the generated .d.ts bindings is invalid! `Array` needs a generic parameter. Oh, I didn't even notice that. I thought the...
I just realized that return and argument types not being the same is a problem for generated getter-setter pairs.
Fixed it in #4202. After #4202 is in, I need to update this PR again, so I'll mark it as a draft for the time being.
Alright, getters and setters are now correct, so this PR is pretty much finished. CI doesn't pass, because CI is currently broken. See #4210, #4213, and #4216.
@daxpedda You know when we talked about `unreachable!()`? We both made the mistake of thinking that `Option`s were always handled in a special branch. We should have [read the code](https://github.com/rustwasm/wasm-bindgen/blob/b45cfb6ced0f591acdeb9578edc993cc13a09b57/crates/cli-support/src/js/binding.rs#L323)...
Okay, there is one more thing I need to put out there. I noticed that one of our TS tests failed. This test defined Rust struct like this: ```rs #[wasm_bindgen]...