Patrik Oldsberg

Results 406 comments of Patrik Oldsberg
trafficstars

Thank you for these suggestions! Looks good imo 👍 Curious if there are any thought on this from anyone else in the community, would this be something you want to...

Won't jump on this immediately as I imagine this might be a slightly controversial topic due to the end user impact. Will look for feedback on the community for this...

@afscrome not sure the brower-only implementation is too much of an issue tbh? If an attacker has that level of control no kind of backend integration is really gonna help...

I like it! 👍 (the original proposal). Deferring to an entity lookup in the backend is the most flexible and preferred (if advanced) approach. You may want to forward the...

Happened to fix this while doing some separate work 😅 -> #22761

@paulkirkwood would it be reasonable to bake this into your `factRetriever` implementation for now? Using the Azure integration utilities provided by https://github.com/backstage/backstage/tree/master/packages/integration? More general SCM integration is something that's on...

Do you feel strongly about having this be part of the CLI? I'm feeling it's perhaps a bit of an odd use-case compared to using JSONSchema tools directly? or it...

@jamieklassen any chance there's something you spot here at a glance? 😅 🙏

@sennyeya on the first point, totally, just forgot to include that goal in the initial PR, update in #22609 For the last point I'm sure I understand the exact concern,...

Highlighting the discussion about auth header size here as something to address: https://github.com/backstage/backstage/pull/22634#discussion_r1474637138