Rasmus Christiansen

Results 164 comments of Rasmus Christiansen
trafficstars

Salt round of 10 is good as standard IMHO :-)

I'm not that convinced that fixed array is faster, but maybe that could just be my lack of skills: ![image](https://user-images.githubusercontent.com/1877612/30913396-57dfd3dc-a390-11e7-8098-3577460984e5.png)

Better, but still way slower than 'pure string concatenation': ![image](https://user-images.githubusercontent.com/1877612/30914275-6a9c3882-a393-11e7-88a7-d827fd90d312.png)

It is the last joining that kills the usage of array: ![image](https://user-images.githubusercontent.com/1877612/30914414-ee426eb8-a393-11e7-9965-9958fee59799.png)

Indeed: ![image](https://user-images.githubusercontent.com/1877612/31069790-370527d0-a75e-11e7-963c-7e8c3f6d2493.png) I ran the above tests 3 times and all showed the above. IMHO the conclusion is that if the end result is a string use .concat, if the...

Just ran a new benchmark: ![image](https://user-images.githubusercontent.com/1877612/44617742-c2056a00-a868-11e8-8226-cab3b933061f.png) When using res.join it is absolutely the slowest of them all and since we are working with strings then we have to use res.join....

@trvra Is this still relevant or has the commit/changes been included in the npm version?

@trvra Is this still relevant or has the commit/changes been included in the npm version?

@lewispham can you provide a PR? Then @dcodeIO can review it and merge.

@lewispham would you provide a PR?