RubyMoney
Deleted disambiguate_symbol for USD
USD should not have disambiguate_symbol and prices in USD should always be formatted like $10,000, the documentation confirms this: https://github.com/RubyMoney/money/blob/main/lib/money/money/formatter.rb#L181.
Currently, Money.new(100, 'USD').format(disambiguate: true) prints US$1.00, which is wrong and confusing.
but this is correct. There are other currencies that use this symbol, e.g. Mexican Peso. If you're in Mexico you'd think $ means peso, not US dollar. If you're outside of Mexico and US, you, strictly speaking, can't tell.
If this is correct, then the documentation should be updated because it says the opposite.
At the same time, if you really need to disambiguate USD, you can always override the default config with Money::Currency.inherit, so I think, the proposed change is correct.
@igor-alexandrov I've been doing a bit of research and other currencies that also use the $ symbol, like the Mexican Peso as @s-mage mentions or the Canadian dolar, do have a disambiguate_symbol symbol of the form COUNTRYCODE$ and a bit of ChatGPT questioning – I am not yet a currency expert haha – told me that US$ is the valid disambiguated format 😬
I am inclined to think that the documentation is wrong here 🙏🏻 Is this causing you any issues?
@yukideluxe I am okay to keep the configuration as it is now. The documentation should be updated in this case (I will make a PR), also I think it will be good to provide an example of how to delete the disambiguate_symbol for the U.S. dollar in your local config. I will also do this.
@yukideluxe I am okay to keep the configuration as it is now. The documentation should be updated in this case (I will make a PR), also I think it will be good to provide an example of how to delete the
disambiguate_symbolfor the U.S. dollar in your local config. I will also do this.
Thank you! 🙏🏻
Hi there @igor-alexandrov, any idea when you think you could update the documentation? 🙏🏻
