ML icon indicating copy to clipboard operation
ML copied to clipboard

Migrate to wamania/php-stemmer:^4.0

Open alexworks64 opened this issue 7 months ago • 2 comments

Hello,

please update dependency wamania/php-stemmer to version ^4.0 (from current ^3.0) for versions 2.x if possible.

That package works with PHP8.4 with deprecation warnings because of their dependency voku/portable-utf8. In the version 4.0 they replaced voku/portable-utf8 with another package.

When I'm trying to use rubix/ml with PHP8.4, I'm getting many warnings like this because of that package:

Deprecated: voku\helper\UTF8::file_get_contents(): Implicitly marking parameter $offset as nullable is deprecated, the explicit nullable type must be used instead in ...

Thanks!

alexworks64 avatar May 13 '25 15:05 alexworks64

For others, the problem can be temporary fixed, seems like, with composer require "wamania/php-stemmer:4.0 as 3.0"

alexworks64 avatar May 14 '25 12:05 alexworks64

Thanks for the heads up @alexworks64, will work on this ASAP

andrewdalpino avatar Jun 11 '25 04:06 andrewdalpino

@andrewdalpino : Would be great to get an official fix soon. Some Nextcloud packages are awaiting that change.

Thanks in advance!

DerDreschner avatar Aug 20 '25 16:08 DerDreschner

@DerDreschner I will fix this ASAP. Since this project doesn't have alot of funding, I only have 15 minutes per month to work on Rubix-related stuff. If you can wait a month or two I should have this fixed for you. Of course, we also welcome contributions.

From my understanding Nextcloud has been using Rubix ML for almost 5 years now. This could be a great opportunity for Nextcloud to give back to our community by funding developers such as myself. A little goes a long way too - I pay myself the minimum wage where I live for all my open source work. With more funding, I can fix things faster and ultimately bring more value to the project overall.

andrewdalpino avatar Sep 06 '25 17:09 andrewdalpino

@andrewdalpino : Ohh, I'm so sorry for wasting your precious time! I opened a pull request to bump the version. The unit tests run flawless with that change, as expected.

I'm not associated with the company behind Nextcloud at all, only making contributions when I experience issues myself, but as far as I know, both projects (mail and suspicious_login) started as community projects. Yeah, suspicious_login is included in Nextcloud out-of-the-box since version 25, but mail has to be installed separately.

Anyway, I'm on your side, it would be great to see some funding for Rubix ML from the Nextcloud GmbH!

DerDreschner avatar Sep 07 '25 01:09 DerDreschner

Hey @DerDreschner, I appreciate the PR but not the comment about my "precious" time. If you understood how much time I've given to this project over the last 8 years, you would understand that I'm the last person to consider their time too "precious." I was one month away from being homeless after funding the development of Rubix with my own savings between 2017 - 2021. Since then, I set up boundaries that are there to prevent that from happening again.

Regarding, the PR, I will take a look ASAP to make sure there aren't any side-effects. I've also assigned the review to the Engineering Team who may be able to take a look as well. Thank you.

andrewdalpino avatar Sep 09 '25 19:09 andrewdalpino