Inventorio icon indicating copy to clipboard operation
Inventorio copied to clipboard

Breaking Game Incompat with BetterCombat(?)

Open Laifsyn opened this issue 2 years ago • 4 comments

If you have both Inventorio and BetterCombat, when you press F, the item in offhand seems to be deleted. Removing either Inventorio or BetterCombat stops the item from disappearing from offhand - I submitted similar issue at BetterCombat Github issues

recorded testing:https://youtu.be/sZOl_cXWgPU

Mods version: inventorio-1.18-fabric-1.7.0 bettercombat-1.0.10+1.18.2

Fabric loader 0.14.8+

Laifsyn avatar Aug 08 '22 05:08 Laifsyn

Hello! Better Combat dev here. Better Combat requires mixins for its two-handed weapon wielding and dual wielding features to work properly. Related mixins:

  • https://github.com/ZsoltMolnarrr/BetterCombat/blob/1.19.X/src/main/java/net/bettercombat/mixin/PlayerEntityInject.java
  • https://github.com/ZsoltMolnarrr/BetterCombat/blob/1.19.X/src/main/java/net/bettercombat/mixin/LivingEntityInject.java
  • https://github.com/ZsoltMolnarrr/BetterCombat/blob/1.19.X/src/main/java/net/bettercombat/mixin/ServerPlayNetworkHandlerMixin.java

Seems like Invetorio changes fundamentally the way how offhand slot works, hence I think this issue is semantically not resolveable without one of the mods dropping some functionality.

I am open for suggestions.

ZsoltMolnarrr avatar Aug 17 '22 15:08 ZsoltMolnarrr

Hi. I currently don't have time to investigate, but I've added "compatibility with BetterCombat" to the Inventorio 2.0 wishlist

Lizard-Of-Oz avatar Aug 21 '22 13:08 Lizard-Of-Oz

same to me in forge

Landrozaum avatar Sep 23 '22 02:09 Landrozaum

hoping this eventually gets resolved, because both mods would work together incredibly well

SpaceWalkerReal avatar Jan 17 '23 04:01 SpaceWalkerReal