gitflow4idea-plus icon indicating copy to clipboard operation
gitflow4idea-plus copied to clipboard

Feature Request - Finish buttons to have a confirmation prompt

Open hodashirzad opened this issue 1 year ago • 1 comments

  • I'm submitting a ...

    • [ ] bug report
    • [x] feature request
    • [ ] puppy => You're not submitting a puppy. I already have one and he's adorable
  • What is the current behavior?

When clicking on any of the Finish options it executes without user confirmation

  • Is this a bug? Sorry about that. If so give me explicit details how to reproduce:

No not really!

  • What is the expected behavior?

It would be great if there is a confirmation dialogue such as Are you sure you want to Finish (Feature / Hotfix / etc)

  • What is the motivation / use case for changing the behavior?

If like me you sometimes clicking fast and accidentally press Finish Feature instead of Start Feature you are into a lot of unnecessary undoing.

  • Please tell me about your environment:

    • Gitflow4idea version: 0.7.11
    • Gitflow version: 1.12.3
    • PhpStorm 2023.1.2 Build #PS-231.9011.38, built on May 16, 2023 Runtime version: 17.0.6+10-b829.9 amd64 VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
  • Other information (e.g. detailed explanation, stacktrace, related issues, suggestions how to fix, links for me to have context words of praises, pictures of puppies (again with the puppy??) )

Thank you very much for an awesome plugin! ♥️

hodashirzad avatar May 30 '23 15:05 hodashirzad

@hodashirzad Hello, I've already added that feature, but haven't submitted it to the marketplace for review. You can install it offline for now

see https://github.com/RubinCarter/gitflow4idea-plus/releases/tag/0.8.0 see https://github.com/RubinCarter/gitflow4idea-plus#offline-installation

RubinCarter avatar Jul 28 '23 03:07 RubinCarter