SPARQL.js icon indicating copy to clipboard operation
SPARQL.js copied to clipboard

Update typings to RDF/JS

Open RubenVerborgh opened this issue 5 years ago • 4 comments

https://github.com/RubenVerborgh/SPARQL.js/issues/73#issuecomment-647374395

RubenVerborgh avatar Jun 23 '20 08:06 RubenVerborgh

@RubenVerborgh I was having a look at the current typings to see whether I can make a PR for this. Looks to me like the change to be made should focus around the following definition of the Term type:

export type Term = string & { __termBrand: string; };

Do you think it would be enough to change this to use RDF/JS' typings? Or, would it be better to also change the Triple interface to better express which kind of term (named node, literal, ...) can be used as the subject / predicate / object of a triple?

jacoscaz avatar Jun 23 '20 08:06 jacoscaz

I think regular RDF/JS should suffice indeed, thanks!

RubenVerborgh avatar Jun 23 '20 08:06 RubenVerborgh

The new typings with RDF/JS terms are merged to DefinitelyTyped 🎉 https://github.com/DefinitelyTyped/DefinitelyTyped/pull/46159

AlexeyMz avatar Jul 24 '20 07:07 AlexeyMz

Thank you @AlexeyMz !

jacoscaz avatar Jul 24 '20 07:07 jacoscaz